Update XrContextHelperOpenXR.h to obtain native extension from the global navigator object #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfromwork
requested review from
rgerd,
rickfromwork,
ryantrem,
satyapoojasama,
syntheticmagus and
tymlipari
ryantrem
reviewed
Mar 29, 2021
| jsiRuntime.global().getProperty(jsiRuntime, "navigator").asObject(jsiRuntime).hasProperty(jsiRuntime, "xr")) | ||
| { | ||
| return false; | ||
| auto nativeXr = jsiRuntime.global().getProperty(jsiRuntime, "navigator").asObject(jsiRuntime).getProperty(jsiRuntime, "xr").asObject(jsiRuntime); |
Member
There was a problem hiding this comment.
It would be nice if we didn't have to duplicate this quite so much. Like maybe if the pattern here was more like:
if (!jsiRuntime.global().hasProperty(jsiRuntime, "navigator")
{
return false;
}
auto navigator{jsiRuntime.global().getProperty(jsiRuntime, "navigator").asObject(jsiRuntime)};
if (!navigator.hasProperty(jsiRuntime, "xr"))
{
return false;
}
auto nativeXr{navigator.getProperty(jsiRuntime, "xr").asObject(jsiRuntime)};
...
ryantrem
approved these changes
Mar 29, 2021
added 6 commits
March 29, 2021 13:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This review is related to: BabylonJS/BabylonNative#650
In 650, we move the nativeXrContext to be available off the global navigator.xr object. We no longer need to pass in the xr session for initialization/obtaining the xr context.