Skip to content

Move to most recent master of BabylonNative submodule and improve UWP tooling #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2021
Merged

Move to most recent master of BabylonNative submodule and improve UWP tooling #188

merged 4 commits into from
Apr 5, 2021

Conversation

@chrisfromwork
Copy link
Contributor

@chrisfromwork chrisfromwork commented Mar 31, 2021

This review does the following:

  1. Move us to the most recent master commit for BabylonNative
  2. Updates the BabylonReactNative.dll vcxproj to look for a newly named openxr_loaderd.lib library
  3. Adds an additional target to rebuild the cmake generates solutions for BabylonNative static libs

@chrisfromwork chrisfromwork mentioned this pull request Apr 2, 2021
Merged
@chrisfromwork chrisfromwork merged commit f5d17e7 into BabylonJS:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryantrem ryantrem ryantrem approved these changes

@rgerd rgerd Awaiting requested review from rgerd

@bghgary bghgary Awaiting requested review from bghgary

@satyapoojasama satyapoojasama Awaiting requested review from satyapoojasama

@rickfromwork rickfromwork Awaiting requested review from rickfromwork

+1 more reviewer

@tymlipari tymlipari tymlipari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrisfromwork @tymlipari @ryantrem