-
Notifications
You must be signed in to change notification settings - Fork 68
Update graphics contract, Update to latest version of BabylonNative #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9fefcb8
30935df
80054fd
8109934
0c6a883
e30c40d
ff050a3
82e04ba
4dbc1ca
f098c11
fbaace7
dfc8de1
6c8299a
e1c96d6
a8cb04d
14bbcde
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ namespace Babylon | |
|
|
||
| void Initialize(facebook::jsi::Runtime& jsiRuntime, Dispatcher jsDispatcher); | ||
| void Deinitialize(); | ||
| void UpdateView(void* windowPtr, size_t width, size_t height, void* windowTypePtr = nullptr); | ||
| void UpdateView(void* windowPtr, size_t width, size_t height); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ideally, we should be removing Currently I cannot include the headers here without build failure, I'll keep tooling with CMake to so that this works, but it may require making this a library instead of a collection of source files included in another library. I'm no CMake expert, however.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. id suggest redefining the type here or using a void pointer for the time being. We can update include directories for the native modules to track down the headers required to access the window type definition. But right now the native modules aren't precompiled binaries when distributed through npm. So if BabylonNative.h references babylon native headers and our react-native native module references BabylonNative.h, i'm pretty sure wed have to package and distribute all headers required to resolve the windowtype, which is going to be a lot more work/seems beyond the scope of fixing breaking changes.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After chatting offline, I'll go forward with retaining void*. |
||
| void RenderView(); | ||
| void ResetView(); | ||
| void SetMouseButtonState(uint32_t buttonId, bool isDown, uint32_t x, uint32_t y); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit can we have this as a reinterpret_cast()?