Skip to content

Add publish test to pr ci, remove arm build to free up agents #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Add publish test to pr ci, remove arm build to free up agents #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fe7b4f
add publish test to pr ci, remove arm build to free up agents
Jun 7, 2021
32a3a2e
fix path for copying context header
Jun 7, 2021
f0cda0a
fix validate file order
Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,34 @@ jobs:
run: npx gulp buildIOS
working-directory: ./Package

test-publish-android-ios:
runs-on: macos-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v2.3.3
with:
submodules: 'recursive'
- name: Setup CMake
uses: jwlawson/actions-setup-cmake@v1.8
with:
cmake-version: '3.19.6' # See https://gitlab.kitware.com/cmake/cmake/-/issues/22021
- name: Setup Ninja
run: brew install ninja
- name: NPM Install (Playground)
run: npm install
working-directory: ./Apps/Playground
- name: NPM Install (Binary Package)
run: npm install
working-directory: ./Package
- name: Gulp
run: npx gulp
working-directory: ./Package

build-windows:
runs-on: windows-latest
strategy:
matrix:
platform: [x86, x64, ARM, ARM64]
platform: [x86, x64, ARM64]
config: [Debug, Release]
steps:
- name: Checkout Repo
Expand Down
6 changes: 3 additions & 3 deletions Package/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ const copyAndroidFiles = async () => {
});

await new Promise(resolve => {
gulp.src('../Apps/Playground/node_modules/@babylonjs/react-native/submodules/BabylonNative/Dependencies/xr/src/ARCore/Include/*')
gulp.src('../Apps/Playground/node_modules/@babylonjs/react-native/submodules/BabylonNative/Dependencies/xr/Source/ARCore/Include/*')
.pipe(gulp.dest('Assembled/android/include'))
.on('end', resolve);
})
Expand Down Expand Up @@ -395,9 +395,9 @@ const validate = async () => {
`Assembled
Assembled/EngineHook.ts
Assembled/shared
Assembled/shared/BabylonNative.h
Assembled/shared/XrContextHelper.h
Assembled/shared/XrAnchorHelper.h
Assembled/shared/BabylonNative.h
Assembled/EngineView.tsx
Assembled/ios
Assembled/ios/BabylonNativeInterop.mm
Expand Down Expand Up @@ -440,9 +440,9 @@ Assembled/ios/BabylonModule.mm
Assembled/README.md
Assembled/package.json
Assembled/android
Assembled/android/build.gradle
Assembled/android/include
Assembled/android/include/IXrContextARCore.h
Assembled/android/build.gradle
Assembled/android/src
Assembled/android/src/main
Assembled/android/src/main/AndroidManifest.xml
Expand Down