Add helper header for declaring native anchors created outside the babylonnative xr session #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfromwork
requested review from
Alex-MSFT,
bghgary,
rgerd,
ryantrem,
syntheticmagus and
tymlipari
added 2 commits
June 11, 2021 09:56
ryantrem
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates our anchor helper header to allow us to declare xr anchors that were created outside of the babylonnative xr session. With this header, xr anchors created by native modules can be registered by the webxranchorsystem.
This change shouldn't directly impact brn functionality. I have tested it for android ar scenarios.