Skip to content

Don't render when graphics is disabled #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Don't render when graphics is disabled #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Modules/@babylonjs/react-native/shared/BabylonNative.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ namespace Babylon
}

g_graphics->EnableRendering();
m_isRenderingEnabled = true;

std::call_once(m_isGraphicsInitialized, [this]()
{
Expand All @@ -97,7 +98,9 @@ namespace Babylon

void RenderView()
{
if (g_graphics)
// If rendering has not been explicitly enabled, or has been explicitly disabled, then don't try to render.
// Otherwise rendering can be implicitly enabled, which may not be desirable (e.g. after the engine is disposed).
if (g_graphics && m_isRenderingEnabled)
{
g_graphics->StartRenderingCurrentFrame();
g_graphics->FinishRenderingCurrentFrame();
Expand All @@ -115,6 +118,8 @@ namespace Babylon
CreateInitPromise();
});
}

m_isRenderingEnabled = false;
}

void SetMouseButtonState(uint32_t buttonId, bool isDown, uint32_t x, uint32_t y)
Expand Down Expand Up @@ -198,6 +203,7 @@ namespace Babylon
Dispatcher m_jsDispatcher{};

std::shared_ptr<bool> m_isRunning{};
bool m_isRenderingEnabled{};
std::once_flag m_isGraphicsInitialized{};
Plugins::NativeInput* m_nativeInput{};
std::optional<Plugins::NativeXr> m_nativeXr{};
Expand Down