Add NativeOptimizations plugin #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfromwork
suggested changes
Jul 23, 2021
Contributor
chrisfromwork
left a comment
chrisfromwork
left a comment
There was a problem hiding this comment.
Please fix BJS dependencies in BN before updating BJS dependencies in BRN.
chrisfromwork
approved these changes
Jul 23, 2021
Contributor
chrisfromwork
left a comment
chrisfromwork
left a comment
There was a problem hiding this comment.
Feel free to check this in after updating BN commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This change adds the NativeOptimizations plugin to Babylon React Native. For now, this is primarily to improve MergeMeshes perf (about 9x).
Screenshots
Before:
After:
Documentation
N/A
Testing
I did all the tests for iOS and Android. I'm not setup to test Windows (it does compile though!).