Fix cppwinrt version that seems to have breaking changes on build agents #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfromwork
requested review from
bghgary,
rgerd,
rickfromwork,
ryantrem and
tymlipari
bghgary
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
In this change we update nuget and vcxproj's to match the cppwinrt version used by build agents. It seems there are some breaking changes between the cppwinrt version used by BabylonNative (not specified, specific to build agent) vs the cppwinrt version we are using for BRN.
Testing
This change should only impact windows flavors. The main thing to test is the agent build. We have validated that xr rendering works for HoloLens 2 devices with this change.