PR builds and binary package builds for releases #45
Conversation
…e libs we care about into a single build directory
Create binary podspec Update PackageTest app to use binary package
Clean up gulpfile
Remove Build.sh Update Readme regarding creating packages
…eactNative into binary-builds
Fix NDK version in README.md
ryantrem
requested review from
Alex-MSFT,
CedricGuillemet,
bghgary and
syntheticmagus
| def DEFAULT_MIN_SDK_VERSION = 18 | ||
| def DEFAULT_TARGET_SDK_VERSION = 28 | ||
| def DEFAULT_NDK_VERSION = '21.0.6113669' | ||
| def DEFAULT_NDK_VERSION = '21.3.6528147' |
There was a problem hiding this comment.
Just curious, any reason we needed to update the NDK version?
There was a problem hiding this comment.
Ah nevermind I reread the description, this is what is preinstalled on the Github build machines. This version seems relatively new, are we going to need to regularly update the NDK version to keep our PR builds working?
There was a problem hiding this comment.
From the PR description :) "Update the build.gradle files to switch to a different version of the NDK which is pre-installed on GitHub build agents"
There was a problem hiding this comment.
Yeah I saw that, I was also wondering if this version is a moving target, are we going to need to periodically keep track and update this to keep our PR builds working?
There was a problem hiding this comment.
I don't know. I tried not specifying it, but then it just picked some default that is not installed on my machine or on the build agents. :(
As far as I can tell, there is not a way to say "use latest" or anything like that.
The main change here is to update
publish.ymlto now prep the environment for building source code, and then actually building the source usinggulp, and finally publishing the binary package (instead of the source package). I've already created a release to test the full flow and the created package (https://www.npmjs.com/package/@babylonjs/react-native). I have one more package being built and published now, which updates the README.md to remove the steps that are no longer needed since the source is pre-compiled.Additionally, since building the code is now relatively trivial, I am also adding
pr.ymlto facilitate gated PR builds. This duplicates steps frompublish.ymlas there doesn't seem to be any way to share a set of steps across jobs with GitHub Actions/Workflows, but the steps are really simple so meh.