Fix double render on Android release #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #78. The problem is that for some reason on Android specifically in release builds we get an extra app state changed event from React Native and incorrectly start a second render loop. The fix is to store the app state in react state, update it in the app state changed event, and start/stop the render loop as a side effect of an actual change in app state.
I also updated Babylon.js to the latest, which for some reason removed the dependency from loaders to core, which also fixes the issue where we end up with two definitions of
RegisterPluginand break gltf loading. It doesn't look like anything in Babylon.js changed, so the only thing I can think is that this is an issue with NPM itself, maybe if you install the dependencies out of order or something...I also noticed that the
enginereturned byuseEnginewas not getting cleared when the associateduseEffectcleans up (e.g. on unmount and fast refresh). I'm not aware of any problems this was causing, but it was not correct, so I fixed it in this PR as well.