Update to latest Babylon JS/Native and fix iOS flushedQueue issue #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest Babylon Native Switch iOS to use setTimeout to indirectly get the queue flushed, as calling it directly breaks internal UI state Remove the workaround in Android that re-initializes the graphics after initializing as this is no longer an issue
bghgary
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly calling
flushedQueueon iOS has some side effects that I didn't notice in my first test. With some UI transitions, the internal UI state becomes broken. I'm not sure what is going on, but see the comments in the code for more details. We have an active thread on Discord with some Facebook React Native folks, so we'll wait and see if they have a better solution.I also removed the call to reinitialize graphics right after initialization on Android as this no longer seems to be an issue.
Finally, I'm updating both Babylon.js and Babylon Native to the latest. This brings in Babylon.js changes that expose the XR tracking state, and also bring in the Babylon Native XR render loop fix.