Skip to content

Conversation

Copy link

Copilot AI commented Nov 5, 2025

Plan to revert commit 8b9f88b (PR #120) which added the Blob factory function:

  • Understand the changes made in PR Blob: Add factory function #120
  • Verify no dependencies on CreateInstance function
  • Build and test the current codebase to establish baseline
  • Remove CreateInstance from Polyfills/Blob/Include/Babylon/Polyfills/Blob.h
  • Remove CreateInstance from Polyfills/Blob/Source/Blob.h
  • Remove CreateInstance implementation from Polyfills/Blob/Source/Blob.cpp
  • Restore JS_BLOB_CONSTRUCTOR_NAME to original location in Initialize method
  • Remove trailing comma from InstanceMethod in Blob.cpp
  • Build and test to verify changes work correctly
  • Request code review
  • Run security checks
Original prompt

Revert commit 8b9f88b, which was added in PR #120 and implemented a Blob factory function. The new pull request should include all necessary changes to undo this commit and restore the codebase to its prior state, ensuring that any tests or dependent code are also corrected if needed.

This pull request was created as a result of the following prompt from Copilot chat.

Revert commit 8b9f88b, which was added in PR #120 and implemented a Blob factory function. The new pull request should include all necessary changes to undo this commit and restore the codebase to its prior state, ensuring that any tests or dependent code are also corrected if needed.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@alexchuber
Copy link
Contributor

That was an epic fail.

@alexchuber alexchuber closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants