A bunch of miscellaneous fixes #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bghgary
commented
Apr 5, 2024
bghgary
commented
- Move Node-API extensions from Babylon Native into JsRuntimeHost.
- Add helper method to Node-API extensions to get error string from either callstack or message if callstack is not available. Use this method where appropriate (e.g., DefaultUnhandledExceptionHandler) to avoid crash when callstack is not available.
- Add EnableDebugger flag to AppRuntime to allow user configuration.
- Add Node-API defines required for JsRuntimeHost directly into the headers instead in CMake to avoid having all consumers add defines to the compile options.
- Fix an issue in Napi::Error::New to allow Napi::Error to propogate properly.
- Don't throw in Chakra's napi_add_finalizer to avoid compiler warning.
- Fix an issue in XMLHttpRequest where some errors are being dropped.
- Move Node-API extensions from Babylon Native into JsRuntimeHost. - Add helper method to Node-API extensions to get error string from either callstack or message if callstack is not available. Use this method where appropriate (e.g., DefaultUnhandledExceptionHandler) to avoid crash when callstack is not available. - Add EnableDebugger flag to AppRuntime to allow user configuration. - Add Node-API defines required for JsRuntimeHost directly into the headers instead in CMake to avoid having all consumers add defines to the compile options. - Fix an issue in Napi::Error::New to allow Napi::Error to propogate properly. - Don't throw in Chakra's napi_add_finalizer to avoid compiler warning. - Fix an issue in XMLHttpRequest where some errors are being dropped.
ryantrem
reviewed
Apr 8, 2024
ryantrem
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.