Skip to content

Conversation

@skellig-s
Copy link
Contributor

Automation itself is here. There is also an update for the data-ang.

[BUS-603]: updated tests for mocks
[BUS-603]: changelog update
@skellig-s skellig-s force-pushed the feature/BUS-603-implement-mocks-automation-import branch from d12e96c to aecd97c Compare June 1, 2023 10:20
@skellig-s skellig-s requested a review from daiscog June 2, 2023 16:54
@skellig-s skellig-s requested a review from daiscog June 5, 2023 10:38
@daiscog
Copy link
Contributor

daiscog commented Jun 5, 2023

@skellig-s it might be worth searching for all uses of withMocks in all of the template files to see if there are any other things that can be removed now, too.

@skellig-s
Copy link
Contributor Author

@daiscog yes, I also thought about it, but haven't committed it yet. I'll do it shortly, but I think the main idea for withMocks would be only mocks generation, and not all configs and providers we have now

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

87.2% 87.2% Coverage
0.0% 0.0% Duplication

@santam85
Copy link
Contributor

@skellig-s shall I merge and release?

@skellig-s
Copy link
Contributor Author

@santam85 I think yes, all change requests were fulfilled as I remember

@santam85 santam85 merged commit d25bfc9 into main Jun 23, 2023
@santam85 santam85 deleted the feature/BUS-603-implement-mocks-automation-import branch June 29, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants