Skip to content

DX-2243 Update Machine Detection Model Name #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2021
Merged

DX-2243 Update Machine Detection Model Name #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e7b742
DX-2243 Update Machine Detection Model Name
ajrice6713 Sep 27, 2021
5b25f98
Update validate.yml
ajrice6713 Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
deploy:
name: Validate SDK
name: Validate SDK
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -24,7 +24,7 @@ jobs:
USER_NUMBER: ${{ secrets.USER_NUMBER }}
BASE_CALLBACK_URL: ${{ secrets.BASE_CALLBACK_URL }}
- uses: Bandwidth/build-notify-slack-action@v1.0.0
if: always()
if: failure() && !github.event.pull_request.draft
with:
job-status: ${{ job.status }}
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion src/Voice/Models/CreateCallRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class CreateCallRequest implements \JsonSerializable

/**
* @todo Write general description for this property
* @var \BandwidthLib\Voice\Models\MachineDetectionRequest|null $machineDetection public property
* @var \BandwidthLib\Voice\Models\MachineDetectionConfiguration|null $machineDetection public property
*/
public $machineDetection;

Expand Down
2 changes: 1 addition & 1 deletion src/Voice/Models/MachineDetectionRequest.php → .../Models/MachineDetectionConfiguration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
/**
* @todo Write general description for this model
*/
class MachineDetectionRequest implements \JsonSerializable
class MachineDetectionConfiguration implements \JsonSerializable
{
/**
* The machine detection mode. If set to 'async', the detection result will be sent in a
Expand Down
2 changes: 1 addition & 1 deletion tests/ApiTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public function testCreateCallAndGetCallState() {

public function testCreateCallWithAmdAndGetCallState() {
$body = new BandwidthLib\Voice\Models\CreateCallRequest();
$machineDetection = new BandwidthLib\Voice\Models\MachineDetectionRequest();
$machineDetection = new BandwidthLib\Voice\Models\MachineDetectionConfiguration();

$machineDetection->mode = BandwidthLib\Voice\Models\ModeEnum::ASYNC;
$machineDetection->detectionTimeout = 5.0;
Expand Down