DX-2238 Add Matrix Testing #36
Merged
+31
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckoegel
reviewed
Sep 29, 2021
| php-version: ${{ matrix.php-version }} | ||
|
|
||
| - name: Install Packages | ||
| run: composer install |
Contributor
There was a problem hiding this comment.
does that setup install composer globally? and that is why you dont need php composer.phar install
Contributor
Author
There was a problem hiding this comment.
Yep - The action runner has php and composer installed globally with composer added to the path - so no need to install composer in the directory and run the file from the directory in GHA
Co-authored-by: Cameron Koegel <53310569+ckoegel@users.noreply.github.com>
`Element 'phpunit', attribute 'syntaxCheck': The attribute 'syntaxCheck' is not allowed.`
hamermike
approved these changes
Sep 29, 2021
ckoegel
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.