Added VM test script #428
Merged
Added VM test script #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rianquinn
requested changes
Feb 14, 2017
tools/tests/BFTest.sh
Outdated
| @@ -0,0 +1,89 @@ | |||
| check_status() | |||
Member
There was a problem hiding this comment.
Doesn't look like this function is used. Also, you need to put the copyright header in place, and make sure that it starts with #!/bin/bash -e
Author
There was a problem hiding this comment.
check_status is used after every command. It essentially does what the -e flag on the bash shebang does, but it prints out a statement to the serial log file that the Jenkins script is looking for. If I just did the -e flag, the Jenkins script would stall out if there was an error in a command. I added the copyright header and the shebang to the top of the script.
added 3 commits
February 15, 2017 10:09
… OS specific code at start (setup_ubuntu.sh)
rianquinn
approved these changes
Feb 15, 2017
Member
|
Looks great. I will merge once the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the script to be put into each VM to test Bareflank. Script located in hypervisor/tools/tests/BFTest.sh