Skip to content

Conversation

@JDDV
Copy link
Contributor

@JDDV JDDV commented May 18, 2021

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Added the "REQUEST_INSTALL_PACKAGES" permission.

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

Allows an application to request installing packages (permission will open an intent where the user can grant the permission)

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

@JDDV JDDV requested a review from mvanbeusekom May 18, 2021 12:31
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #557 (4796546) into master (25b10ca) will decrease coverage by 12.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##            master     #557       +/-   ##
============================================
- Coverage   100.00%   87.91%   -12.09%     
============================================
  Files            1        6        +5     
  Lines           16       91       +75     
============================================
+ Hits            16       80       +64     
- Misses           0       11       +11     
Impacted Files Coverage Δ
...andler_platform_interface/lib/src/permissions.dart 100.00% <ø> (ø)
permission_handler/lib/permission_handler.dart
...hod_channel/method_channel_permission_handler.dart 100.00% <0.00%> (ø)
..._interface/lib/src/method_channel/utils/codec.dart 100.00% <0.00%> (ø)
...ler_platform_interface/lib/src/service_status.dart 73.33% <0.00%> (ø)
..._platform_interface/lib/src/permission_status.dart 68.18% <0.00%> (ø)
...lib/src/permission_handler_platform_interface.dart 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b10ca...4796546. Read the comment docs.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit a49e4ab into master May 19, 2021
@mvanbeusekom mvanbeusekom deleted the issue/319_permission_handler_platform_interface branch May 19, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants