Skip to content

Conversation

@lavinov-mercury
Copy link
Contributor

@lavinov-mercury lavinov-mercury commented Sep 27, 2022

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This PR fixes, that if Bluetooth is turned off & bluetooth permission is being checked, then the dialog will appear, asking if user want to turn on bluetooth

To reproduce, turn off bluetooth & add the bluetooth permission check somewhere on the app start, then restart the app

⤵️ What is the current behavior?

"AppName" would like to use Bluetooth for new connections dialog will appear

🆕 What is the new behavior (if this is a feature change)?

Now this dialog won't appear

💥 Does this PR introduce a breaking change?

Kind of. Not sure if this dialog is expected behavior for someone, when you just try to check permissions.

📝 Links to relevant issues/docs

https://stackoverflow.com/questions/16412866/ios-corebluetooth-passively-check-if-bluetooth-is-enabled-without-prompting-user

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lavinov-mercury,

Thank you for this PR, looks like a really useful bug fix. Would you please patch the version in the pubspec.yaml and add the matching number to the CHANGELOG.md entry you made?

This would help us publish changes easier.

@lavinov-mercury
Copy link
Contributor Author

@mvanbeusekom Hi! Thanks, i've made these changes, could you please check?

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this contribution.

@mvanbeusekom mvanbeusekom merged commit adf246f into Baseflow:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants