Skip to content

Conversation

@YannickMaljaars
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Added support for new Android 13 permission: NEARBY_WIFI_DEVICES in the platform interface package

⤵️ What is the current behavior?

No support for this permission

🆕 What is the new behavior (if this is a feature change)?

Support for this permission

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

859

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

@YannickMaljaars YannickMaljaars marked this pull request as ready for review September 28, 2022 10:14
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 100.00% // Head: 86.51% // Decreases project coverage by -13.48% ⚠️

Coverage data is based on head (1c82f51) compared to base (9ecea26).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##            master     #927       +/-   ##
============================================
- Coverage   100.00%   86.51%   -13.49%     
============================================
  Files            1        6        +5     
  Lines           16       89       +73     
============================================
+ Hits            16       77       +61     
- Misses           0       12       +12     
Impacted Files Coverage Δ
...andler_platform_interface/lib/src/permissions.dart 91.66% <ø> (ø)
permission_handler/lib/permission_handler.dart
...lib/src/permission_handler_platform_interface.dart 100.00% <0.00%> (ø)
..._interface/lib/src/method_channel/utils/codec.dart 100.00% <0.00%> (ø)
...hod_channel/method_channel_permission_handler.dart 100.00% <0.00%> (ø)
..._platform_interface/lib/src/permission_status.dart 66.66% <0.00%> (ø)
...ler_platform_interface/lib/src/service_status.dart 71.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants