Skip to content

Add null safety to Firebase cache manager #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2021
Merged

Add null safety to Firebase cache manager #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e46e3fb
Add null safety and upgrade dependencies
percula Mar 9, 2021
23706e2
Update version
percula Mar 9, 2021
32dd291
use lazy loading of instance
renefloor May 28, 2021
c4b5ee6
update changelog and pubspec
renefloor May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flutter_cache_manager_firebase/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## [2.0.0] - 2021-05-28
* Update to null safety

## [1.1.0] - 2021-01-14
* Update Firebase dependency

Expand Down
3 changes: 1 addition & 2 deletions flutter_cache_manager_firebase/lib/src/firebase_cache_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ import 'firebase_http_file_service.dart';
class FirebaseCacheManager extends CacheManager {
static const key = 'firebaseCache';

static FirebaseCacheManager _instance;
static late final FirebaseCacheManager _instance = FirebaseCacheManager._();

factory FirebaseCacheManager() {
_instance ??= FirebaseCacheManager._();
return _instance;
}

Expand Down
4 changes: 2 additions & 2 deletions flutter_cache_manager_firebase/lib/src/firebase_http_file_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import 'package:flutter_cache_manager/flutter_cache_manager.dart';
class FirebaseHttpFileService extends HttpFileService {
@override
Future<FileServiceResponse> get(String url,
{Map<String, String> headers = const {}}) async {
{Map<String, String>? headers}) async {
var ref = FirebaseStorage.instance.ref().child(url);
var _url = await ref.getDownloadURL() as String;
var _url = await ref.getDownloadURL();

return super.get(_url);
}
Expand Down
12 changes: 6 additions & 6 deletions flutter_cache_manager_firebase/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
name: flutter_cache_manager_firebase
description: CacheManager implementation for firebase_storage. Uses the gs:// as key and translates to https://
version: 1.1.0
version: 2.0.0
homepage: https://github.com/Baseflow/flutter_cache_manager

environment:
sdk: ">=2.7.0 <3.0.0"
sdk: ">=2.12.0-0 <3.0.0"

dependencies:
flutter:
sdk: flutter
flutter_cache_manager: ^2.0.0
firebase_storage: ">=3.0.0 <6.0.0"
path_provider: "^1.4.0"
path: "^1.6.4"
flutter_cache_manager: ^3.0.0
firebase_storage: ^8.0.0
path_provider: ^2.0.0
path: ^1.8.0

dev_dependencies:
flutter_test:
Expand Down