Skip to content

Conversation

@renefloor
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix similar to #321

⤵️ What is the current behavior?

File is always imported with the library conflicting with dart:io

🆕 What is the new behavior (if this is a feature change)?

Give the user of the library a different way to import the file class

💥 Does this PR introduce a breaking change?

It reverts a breaking change

🐛 Recommendations for testing

📝 Links to relevant issues/docs

Fixes #320

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@renefloor
Copy link
Contributor Author

@sidrao2006, @akadatsky and @aideric.
What do you think of this solution? This way the default import

import 'package:flutter_cache_manager/flutter_cache_manager.dart';

won't conflict with dart:io, but you'll still have the option to add an import with

import 'package:flutter_cache_manager/file.dart';

@sidrao2006
Copy link
Contributor

Yep, this is better than having to add file as a direct dependency

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #324 (11c6dc5) into develop (b1e9807) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #324   +/-   ##
========================================
  Coverage    74.85%   74.85%           
========================================
  Files           21       21           
  Lines          672      672           
========================================
  Hits           503      503           
  Misses         169      169           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e9807...11c6dc5. Read the comment docs.

@renefloor renefloor merged commit 2555fe6 into develop Jun 3, 2021
@renefloor renefloor deleted the bugfix/fix-file branch June 3, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File in flutter_cache_manage conflict with File in dart.io

3 participants