Skip to content

Plugin/projects: cleanup #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2022
Merged

Plugin/projects: cleanup #2010

merged 3 commits into from
Jan 25, 2022

Conversation

@gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Dec 31, 2021

Description

shfmt, shellcheck, and minor cleanup.

Motivation and Context

Just cleaning up.

How Has This Been Tested?

Types of changes

  • Cleanup (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard force-pushed the plugin-projects branch 2 times, most recently from ea5a074 to 9bc5dbf Compare December 31, 2021 07:53
@gaelicWizard gaelicWizard marked this pull request as ready for review December 31, 2021 07:57
@gaelicWizard gaelicWizard changed the title plugin/projects: cleanup Plugin/projects: cleanup Dec 31, 2021
@gaelicWizard gaelicWizard force-pushed the plugin-projects branch 3 times, most recently from 1eef67c to fb65e0b Compare January 2, 2022 01:50
NoahGorny
NoahGorny reviewed Jan 3, 2022
View reviewed changes
@gaelicWizard gaelicWizard force-pushed the plugin-projects branch 2 times, most recently from eb8fe39 to 6524e1f Compare January 4, 2022 02:04
@gaelicWizard gaelicWizard requested a review from NoahGorny January 4, 2022 02:04
NoahGorny
NoahGorny reviewed Jan 8, 2022
View reviewed changes
gaelicWizard and others added 2 commits January 18, 2022 11:08
@gaelicWizard
plugin/projects: cleanup
ea2002a 
I'm deliberately leaving the possibility that one might `pjo` without a project name...
@gaelicWizard
plugin/projects: add to template/bash_profile
1ec48c8
@gaelicWizard gaelicWizard force-pushed the plugin-projects branch 3 times, most recently from 5a6e18a to d9ccd4a Compare January 19, 2022 04:42
@gaelicWizard
Copy link
Contributor Author

gaelicWizard commented Jan 19, 2022

I rebased on current master and refactored a bit. I think this one should be more reliable, and should help the user figure it out if needed.

@NoahGorny NoahGorny merged commit 2575d64 into Bash-it:master Jan 25, 2022
@gaelicWizard gaelicWizard deleted the plugin-projects branch January 25, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaelicWizard @NoahGorny