Skip to content

lib/preview: functionalize #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2022
Merged

lib/preview: functionalize #2017

merged 3 commits into from
Feb 13, 2022

Conversation

@gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Jan 3, 2022 •
edited
Loading

Description

Refactor in to a function, but continue to support current usage.

Motivation and Context

This allows running the preview without reloading the startup files multiple times, and alsö integrate to bash-it function, and alsö alsö offer it's own completions.

How Has This Been Tested?

Tested locally and all tests pass.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as ready for review January 3, 2022 04:38
NoahGorny
NoahGorny requested changes Jan 3, 2022
View reviewed changes
@gaelicWizard gaelicWizard force-pushed the lib/preview branch 2 times, most recently from 2b466d0 to 3cb9f12 Compare January 4, 2022 02:13
@gaelicWizard gaelicWizard requested a review from NoahGorny January 4, 2022 02:13
@gaelicWizard gaelicWizard force-pushed the lib/preview branch 4 times, most recently from f8deb65 to 95eeb7f Compare January 4, 2022 23:02
NoahGorny
NoahGorny reviewed Jan 7, 2022
View reviewed changes
@gaelicWizard gaelicWizard force-pushed the lib/preview branch 2 times, most recently from b16568c to 3b2ecc2 Compare January 8, 2022 17:06
@gaelicWizard gaelicWizard requested a review from NoahGorny January 8, 2022 17:35
@gaelicWizard gaelicWizard changed the title lib/preview: slight refactor lib/preview: functionalize Jan 8, 2022
NoahGorny
NoahGorny reviewed Jan 8, 2022
View reviewed changes
@gaelicWizard
Copy link
Contributor Author

gaelicWizard commented Jan 10, 2022

I've expanded the _bash-it-preview() function to offer it's own completions, theme names!

@gaelicWizard gaelicWizard force-pushed the lib/preview branch 5 times, most recently from b77723b to c0350b1 Compare January 13, 2022 03:38
NoahGorny
NoahGorny approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaelicWizard
Copy link
Contributor Author

gaelicWizard commented Jan 18, 2022

Rebased on current master and ready to go!

@gaelicWizard gaelicWizard force-pushed the lib/preview branch 4 times, most recently from facbcf5 to 295f646 Compare January 25, 2022 21:52
@gaelicWizard gaelicWizard force-pushed the lib/preview branch 2 times, most recently from 8580d0a to af2d569 Compare January 30, 2022 07:16
@gaelicWizard
lib/preview: refactor into a function
d6555f3 
This allows future use like `bash-it preview`. Alsö, allows to use `$BASH_PREVIEW` to specify a particular theme to preview instead of just doing all of them.
@gaelicWizard
lib/helpers: add preview to bash-it spaghetti
a9a40a3
@gaelicWizard
lib/preview: add full completion
00e3955
@NoahGorny NoahGorny merged commit 89c9504 into Bash-it:master Feb 13, 2022
@gaelicWizard gaelicWizard deleted the lib/preview branch February 13, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaelicWizard @NoahGorny