Skip to content

Feature/menu fast access #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Feature/menu fast access #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df2aebc
feat (FastAccess) : add fast access navigation
firestar300 Nov 23, 2021
e421998
fix (package) : author name
firestar300 Nov 24, 2021
91953ba
feat (skip-links) : change className and add french strings
firestar300 Nov 24, 2021
3b3af6d
feat (header/footer) : add default structure markup
firestar300 Nov 25, 2021
ee48632
feat (header/footer) : add aria-labels
firestar300 Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions footer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
</main>
<footer id="footer" class="footer" role="contentinfo" aria-label="Pied de page"></footer>
<?php wp_footer(); ?>
</body>
</html>
12 changes: 12 additions & 0 deletions header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,17 @@
<?php wp_head(); ?>
</head>
<body <?php body_class(); ?>>
<ul class="skip-links skip-links--hidden" aria-label="Liens d'évitement">
<li>
<a href="#content">Contenu principal</a>
</li>
<li>
<a href="#footer">Pied de page</a>
</li>
</ul>

<header id="header" class="header" role="banner" aria-label="Entête de page"></header>

<main id="content" role="main" tabindex="-1" aria-label="Zone de contenus">
<?php
wp_body_open();
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "beapi-frontend-framework",
"version": "5.0.0",
"author": "BeAPI",
"author": "Be API",
"repository": {
"type": "git",
"url": "https://github.com/BeAPI/beapi-frontend-framework"
Expand Down
1 change: 0 additions & 1 deletion src/scss/patterns/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
.footer {
$el: &;

padding-bottom: $base-spacing;
text-align: center;
}
5 changes: 4 additions & 1 deletion src/scss/patterns/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@
*/

.header {
position: fixed;
top: 0;
right: 0;
left: 0;
padding-top: $base-spacing;
padding-bottom: $base-spacing;
background-color: $primary-color;

&__logo-link {
display: block;
Expand Down
20 changes: 20 additions & 0 deletions src/scss/patterns/_skip-links.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
.skip-links {
position: absolute;
top: 0;
left: 0;
z-index: 10;
display: flex;
padding: .5rem 1rem;
color: $secondary-color;
background-color: $primary-color;
transition: transform .3s ease-in-out;
transform: translate3d(0, -100%, 0);

&:focus-within {
transform: translate3d(0, 0, 0);
}

li:not(:last-of-type) {
margin-right: 1rem;
}
}
1 change: 1 addition & 0 deletions src/scss/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ $entry-file-name: "style";
@import "patterns/menu";
@import "patterns/hero";
@import "patterns/searchform";
@import "patterns/skip-links";

// Wordpress

Expand Down