Skip to content

feat (ie) remove old dependencies and update message #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2019
Merged

feat (ie) remove old dependencies and update message #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,18 @@
<body <?php body_class(); ?>>
<?php wp_body_open(); ?>
<!--[if lte IE 9]>
<div class="message message__browserhappy">
<div class="message message--outdated" id="js-ieMessage">
<p>
You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/" target="_blank">upgrade your browser</a> to improve your experience.
</p>
<p>
<button><span class="button-icon icon-close"></span>&nbsp;Close</button>
<button class="button" id="js-ieClose">Close</button>
</p>
</div>
<script>
var ieClose = document.getElementById('js-ieClose')
var ieMessage = document.getElementById('js-ieMessage')
function ieCLosMsg() { ieMessage.style.display = 'none' }
ieClose.addEventListener('click', ieCLosMsg)
</script>
<![endif]-->
8 changes: 0 additions & 8 deletions inc/services/assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,6 @@ public function register_assets() {
$this->assets_tools->register_script( 'placeholders', 'dist/assets/js/vendor_ie/placeholders.min.js', [], '1', false );
wp_script_add_data( 'placeholders', 'conditional', 'lte IE 9' );

$this->assets_tools->register_script( 'html5shiv', 'dist/assets/js/vendor_ie/html5shiv.min.js', [], '1', false );
wp_script_add_data( 'html5shiv', 'conditional', 'lt IE 9' );

$this->assets_tools->register_script( 'selectivizr', 'dist/assets/js/vendor_ie/selectivizr.js', [], '1', false );
wp_script_add_data( 'selectivizr', 'conditional', 'lte IE 8' );

// Async and footer
$file = ( ! defined( 'SCRIPT_DEBUG' ) || SCRIPT_DEBUG === false ) ? $this->get_min_file( 'js' ) : 'app.js';
$this->assets_tools->register_script( 'scripts', 'dist/assets/' . $file, $scripts_dependencies, $theme->get( 'Version' ), true );
Expand All @@ -89,8 +83,6 @@ public function enqueue_scripts() {
$this->assets_tools->enqueue_script( 'matchMedia-polyfill' );
$this->assets_tools->enqueue_script( 'matchMedia-addListener' );
$this->assets_tools->enqueue_script( 'placeholders' );
$this->assets_tools->enqueue_script( 'html5shiv' );
$this->assets_tools->enqueue_script( 'selectivizr' );
$this->assets_tools->enqueue_script( 'scripts' );
}

Expand Down
1 change: 0 additions & 1 deletion src/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import lazySizes from 'lazysizes'
import 'lazysizes/plugins/bgset/ls.bgset'
import 'lazysizes/plugins/native-loading/ls.native-loading'

import './src/ie_message'
import './src/menu'
import './src/button-href'
import './src/wrapper'
Expand Down
8 changes: 0 additions & 8 deletions src/js/src/ie_message.js
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/js/vendor_ie/html5shiv.min.js
View file
Open in desktop

This file was deleted.

Loading