-
Notifications
You must be signed in to change notification settings - Fork 18
Feature/polyfills #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and 200kb in app.js !!
7.4.5 => 7.6.4
|
@Rahe poke |
Rahe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok pour moi, attention aux fichiers JS chargés en dur, ils ne pourrons pas être minifiés/concaténés.
|
@Rahe et tu est ok pour l'emplacement dans ce fichier ? |
|
C'est bien le point de mon commentaire, si posé ici ,pas de concaténation, pas de priorisation/dé-priorisation. Il a besoin d'être lié au loadJS absolument ? |
|
Pas absolument. L'important c'est d'avoir le polyfill avant app.js. Pas besoin de concaténation/minification. c'est un service tiers qui adapte son build en fonction de ton navigateur. Donc sur les navigateurs récents on aura un fichier quasiment vide, ie11 ce sera un peu plus lourd. |
@Rahe We change our polyfill strategy in order to provide lighter build for modern browsers. polyfill.io is doing the job for older browser.
We need to load it before font loading and app.js, you can view example in src/templates/partials/footer.php
For WP now it's in inc/async/loadfont.php ok for you ? Or can we have a single file shared between static/wp ?
Thx