Fix: Prevent Console Re-Patching and Handle Disabling on Configure #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great find, I had never thought of that possibility. I'll go ahead and merge it right away and create a new release. Thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82
Without this, everytime
configureis called due to hot reload, console.log will have 1 extra stack, and with enough hot reloads, it will stackoverflow, but will be triggered by until.inspect, which internally uses str.replace and throw "Maximum regex stack depth reached" errorSummary of Changes:
consoleobject from being patched multiple times by adding a guard in theenableConsoleCapturemethod.configuremethod has been updated to correctly disable console capturing when thecaptureConsoleoption is set tofalse.