added crude multi-threading #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OKUA1
requested changes
Jun 8, 2024
Collaborator
OKUA1
left a comment
OKUA1
left a comment
There was a problem hiding this comment.
Hi, please see the comment regarding the usage of the warnings.
skllm/models/_base/classifier.py
Outdated
| predictions.append(self._predict_single(X[i])) | ||
|
|
||
| if num_workers > 1: | ||
| raise DeprecationWarning("Passing num_workers to predict is temporary and will be removed in the future.") |
Collaborator
There was a problem hiding this comment.
I don't think raising is preferred here as it interrupts the execution. I would suggest using warnings.warn instead.
Contributor
Author
|
I'll add some documentation for this next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to pass num_workers to predict to speed up inference.
Tested for Zero, Few and Dynamic shot classes.