Skip to content

Conversation

SubaruArai
Copy link
Contributor

#293 added RetryNodeTypo with deprecated warning.

@facontidavide facontidavide merged commit 4c9807a into BehaviorTree:master Oct 13, 2021
@facontidavide
Copy link
Collaborator

You broke the build https://github.com/BehaviorTree/BehaviorTree.CPP/actions/runs/1336466786

@SubaruArai
Copy link
Contributor Author

@facontidavide Oops, I'm investigating

@SubaruArai
Copy link
Contributor Author

Found the problem, looks like I misunderstood how inheritance works in C++.
All I needed was a public inheritance.

@sarcasticnature
Copy link
Contributor

sarcasticnature commented Oct 13, 2021

I fixed the issue in my fork on this branch/commit, also correcting the documentation to use the updated spelling.

@facontidavide should I create a new PR with my additions?

@facontidavide
Copy link
Collaborator

yes please. Have you checked that unit tests compile and run?

@sarcasticnature
Copy link
Contributor

yes, PR incoming

@SubaruArai
Copy link
Contributor Author

@sarcasticnature Thank you!
@facontidavide Sorry & thank you for being patient!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants