Skip to content

Add tests for Handling API responses #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 25, 2023
Merged

Add tests for Handling API responses #170

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f53578
Update eclipse settings
May 23, 2023
8dda127
resolve warnings
Selindek May 24, 2023
293a11a
add tests
Selindek May 24, 2023
a0c674c
Merge branch 'main' into update-eclipse-settings
Selindek May 25, 2023
3ae642b
fsi
Selindek May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions xapi-client/src/test/java/dev/learning/xapi/client/XapiClientTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.web.reactive.function.client.WebClient;
import org.springframework.web.reactive.function.client.WebClientResponseException.BadRequest;
import org.springframework.web.reactive.function.client.WebClientResponseException.InternalServerError;

/**
* XapiClient Tests.
Expand Down Expand Up @@ -379,6 +381,67 @@ void whenPostingStatementThenContentTypeHeaderIsApplicationJson() throws Interru
assertThat(recordedRequest.getHeader("content-type"), is("application/json"));
}

@Test
void givenApiResponseIsEmptyWhenPostingStatementThenMissingResponseBodyExceptionIsThrown() {

// Given Api Response Is Empty
mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 200 OK").setHeader("Content-Type",
"application/json"));

// When Posting Statement
final var response = client.postStatement(r -> r
.statement(s -> s.agentActor(a -> a.name("A N Other").mbox("mailto:another@example.com"))

.verb(Verb.ATTEMPTED)

.activityObject(o -> o.id("https://example.com/activity/simplestatement")
.definition(d -> d.addName(Locale.ENGLISH, "Simple Statement")))));

// Then MissingResponseBodyException Is Thrown
assertThrows(MissingResponseBodyException.class, () -> response.block());

}

@Test
void givenApiResponseIsBadRequestWhenPostingStatementThenBadRequestIsThrown() {

// Given Api Response Is Bad Request
mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 400 Bad Request"));

// When Posting Statement
final var response = client.postStatement(r -> r
.statement(s -> s.agentActor(a -> a.name("A N Other").mbox("mailto:another@example.com"))

.verb(Verb.ATTEMPTED)

.activityObject(o -> o.id("https://example.com/activity/simplestatement")
.definition(d -> d.addName(Locale.ENGLISH, "Simple Statement")))));

// Then BadRequest Is Thrown
assertThrows(BadRequest.class, () -> response.block());

}

@Test
void givenApiResponseIsInternalServerErrorWhenPostingStatementThenInternalServerErrorIsThrown() {

// Given Api Response Is Internal Server Error
mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 500 Internal Server Error"));

// When Posting Statement
final var response = client.postStatement(r -> r
.statement(s -> s.agentActor(a -> a.name("A N Other").mbox("mailto:another@example.com"))

.verb(Verb.ATTEMPTED)

.activityObject(o -> o.id("https://example.com/activity/simplestatement")
.definition(d -> d.addName(Locale.ENGLISH, "Simple Statement")))));

// Then InternalServerError Is Thrown
assertThrows(InternalServerError.class, () -> response.block());

}

// Posting a Signed Statement

@Test
Expand Down