Skip to content

Fix scaled score is optional #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Fix scaled score is optional #42

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
282d1b1
Fix scaled value in score is optional
Feb 3, 2023
45f2ed3
tip
Feb 3, 2023
e47afdf
Merge branch 'main' into fix_scaled_score_is_optional
thomasturrell Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xapi-model/src/main/java/dev/learning/xapi/model/Score.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@
@JsonInclude(Include.NON_EMPTY)
public class Score {

// TODO check that @DecimalMax and @DecimalMin apply to float
/**
* The score related to the experience as modified by scaling and/or normalization.
*/
@DecimalMax(value = "1.0")
@DecimalMin(value = "-1.0")
private float scaled;
private Float scaled;

/**
* The score achieved by the Actor in the experience described by the Statement.
Expand Down