Skip to content

Fixes to #429 #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2020
Merged

Fixes to #429 #430

merged 1 commit into from
Sep 26, 2020

Conversation

@dilawar
Copy link
Contributor

@dilawar dilawar commented Sep 25, 2020

This fixes #429. If a user try to delete a non-existent path, moose raises a ValueError exception.

@dilawar dilawar mentioned this pull request Sep 25, 2020
Closed
hrani
hrani approved these changes Sep 26, 2020
View reviewed changes
Copy link
Contributor

@hrani hrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay

@hrani hrani merged commit 7b93bfd into BhallaLab:master Sep 26, 2020
@dilawar dilawar deleted the issue_429 branch September 26, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hrani hrani hrani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

seg fault moose.delete('/test') for non exist object

2 participants

@dilawar @hrani