Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routes/api.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
Route::delete('/{repository}/{repositoryId}', '\\'.RepositoryDestroyController::class);

// Fields
Route::delete('/{repository}/{repositoryId}/field/{field}', '\\' . FieldDestroyController::class);
Route::delete('/{repository}/{repositoryId}/field/{field}', '\\'.FieldDestroyController::class);

// Attach related repository id
Route::post('/{repository}/{repositoryId}/attach/{relatedRepository}', '\\'.RepositoryAttachController::class);
Expand Down
17 changes: 8 additions & 9 deletions src/Fields/File.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Binaryk\LaravelRestify\Fields;

use Binaryk\LaravelRestify\Contracts\FileStorable as StorableContract;
use Binaryk\LaravelRestify\Contracts\Deletable as DeletableContract;
use Binaryk\LaravelRestify\Contracts\FileStorable as StorableContract;
use Binaryk\LaravelRestify\Fields\Concerns\AcceptsTypes;
use Binaryk\LaravelRestify\Fields\Concerns\Deletable;
use Binaryk\LaravelRestify\Fields\Concerns\FileStorable;
Expand Down Expand Up @@ -82,10 +82,10 @@ public function storeAs($storeAs): self
protected function prepareStorageCallback(callable $storageCallback = null): void
{
$this->storageCallback = $storageCallback ?? function ($request, $model) {
return $this->mergeExtraStorageColumns($request, [
$this->attribute => $this->storeFile($request, $this->attribute),
]);
};
return $this->mergeExtraStorageColumns($request, [
$this->attribute => $this->storeFile($request, $this->attribute),
]);
};
}

/**
Expand Down Expand Up @@ -116,7 +116,7 @@ public function storeSize($column)

protected function storeFile(Request $request, string $requestAttribute)
{
if (!$this->storeAs) {
if (! $this->storeAs) {
return $request->file($requestAttribute)->store($this->getStorageDir(), $this->getStorageDisk());
}

Expand All @@ -142,7 +142,6 @@ public function store($storageCallback): self
return $this;
}


/**
* Merge the specified extra file information columns into the storable attributes.
*
Expand Down Expand Up @@ -187,7 +186,7 @@ protected function columnsThatShouldBeDeleted(): array

public function fillAttribute(RestifyRequest $request, $model, int $bulkRow = null)
{
if (is_null($file = $request->file($this->attribute)) || !$file->isValid()) {
if (is_null($file = $request->file($this->attribute)) || ! $file->isValid()) {
return $this;
}

Expand All @@ -208,7 +207,7 @@ public function fillAttribute(RestifyRequest $request, $model, int $bulkRow = nu
return $result;
}

if (!is_array($result)) {
if (! is_array($result)) {
return $model->{$attribute} = $result;
}

Expand Down
4 changes: 2 additions & 2 deletions src/Http/Controllers/Concerns/DeletesFields.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ protected function deleteFields(RestifyRequest $request, $model)
($repository = $request->newRepositoryWith($model))
->collectFields($request)
->whereInstanceOf(Deletable::class)
->filter(fn(Field $field) => $field instanceof Deletable)
->filter(fn(Deletable $field) => $field->isPrunable())
->filter(fn (Field $field) => $field instanceof Deletable)
->filter(fn (Deletable $field) => $field->isPrunable())
->resolve($repository)
->each(function ($field) use ($request, $model) {
DeleteField::forRequest($request, $field, $model)->save();
Expand Down
3 changes: 1 addition & 2 deletions src/Http/Controllers/FieldDestroyController.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace Binaryk\LaravelRestify\Http\Controllers;

use Binaryk\LaravelRestify\Contracts\Deletable;
use Binaryk\LaravelRestify\Fields\Field;
use Binaryk\LaravelRestify\Http\Requests\RestifyRequest;
use Binaryk\LaravelRestify\Repositories\DeleteField;
use Illuminate\Routing\Controller;
Expand All @@ -20,7 +19,7 @@ public function __invoke(RestifyRequest $request)

$field = $repository->collectFields($request)
->whereInstanceOf(Deletable::class)
->filter(fn(Deletable $field) => $field->isDeletable())
->filter(fn (Deletable $field) => $field->isDeletable())
->resolve($repository)
->findFieldByAttribute($request->field, function () {
abort(404);
Expand Down
2 changes: 1 addition & 1 deletion src/Repositories/DeleteField.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public static function forRequest(RestifyRequest $request, $field, $model): Mode
return $model;
}

if (!is_array($result)) {
if (! is_array($result)) {
$model->{$field->getAttribute()} = $result;
} else {
foreach ($result as $key => $value) {
Expand Down
3 changes: 1 addition & 2 deletions tests/Controllers/ProfileControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Binaryk\LaravelRestify\Tests\Controllers;

use Binaryk\LaravelRestify\Fields\File;
use Binaryk\LaravelRestify\Fields\Image;
use Binaryk\LaravelRestify\Tests\Fixtures\User\User;
use Binaryk\LaravelRestify\Tests\Fixtures\User\UserRepository;
Expand Down Expand Up @@ -220,7 +219,7 @@ public function test_can_upload_avatar()
->disk('customDisk')
->storeOriginalName('avatar_original')
->storeSize('avatar_size')
->storeAs('avatar.jpg')
->storeAs('avatar.jpg'),
]);

$this->post('profile', [
Expand Down
24 changes: 12 additions & 12 deletions tests/Fields/FileTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ public function test_can_upload_file()
->disk('customDisk')
->storeOriginalName('avatar_original')
->storeSize('avatar_size')
->storeAs('avatar.jpg')
->storeAs('avatar.jpg'),
]);

$user = $this->mockUsers()->first();

$this->post(UserRepository::uriKey() . "/{$user->id}", [
$this->post(UserRepository::uriKey()."/{$user->id}", [
'avatar' => UploadedFile::fake()->image('image.jpg'),
])->assertOk()->assertJsonFragment([
'avatar_original' => 'image.jpg',
Expand Down Expand Up @@ -90,10 +90,10 @@ public function test_can_prune_prunable_files()
Image::make('avatar')
->disk('customDisk')
->prunable()
->storeAs('avatar.jpg')
->storeAs('avatar.jpg'),
]);

$this->delete(UserRepository::uriKey() . "/{$user->id}")
$this->delete(UserRepository::uriKey()."/{$user->id}")
->dump()
->assertNoContent();

Expand All @@ -114,10 +114,10 @@ public function test_cannot_prune_unpruneable_files()
UserRepository::partialMock()
->shouldReceive('fields')
->andReturn([
Image::make('avatar')->disk('customDisk')->storeAs('avatar.jpg')
Image::make('avatar')->disk('customDisk')->storeAs('avatar.jpg'),
]);

$this->delete(UserRepository::uriKey() . "/{$user->id}")
$this->delete(UserRepository::uriKey()."/{$user->id}")
->assertNoContent();

Storage::disk('customDisk')->assertExists('avatar.jpg');
Expand All @@ -137,10 +137,10 @@ public function test_deletable_file_could_be_deleted()
UserRepository::partialMock()
->shouldReceive('fields')
->andReturn([
Image::make('avatar')->disk('customDisk')->storeAs('avatar.jpg')->deletable(true)
Image::make('avatar')->disk('customDisk')->storeAs('avatar.jpg')->deletable(true),
]);

$this->delete(UserRepository::uriKey() . "/{$user->id}/field/avatar")
$this->delete(UserRepository::uriKey()."/{$user->id}/field/avatar")
->assertNoContent();

Storage::disk('customDisk')->assertMissing('avatar.jpg');
Expand All @@ -160,10 +160,10 @@ public function test_not_deletable_file_cannot_be_deleted()
UserRepository::partialMock()
->shouldReceive('fields')
->andReturn([
Image::make('avatar')->disk('customDisk')->storeAs('avatar.jpg')->deletable(false)
Image::make('avatar')->disk('customDisk')->storeAs('avatar.jpg')->deletable(false),
]);

$this->delete(UserRepository::uriKey() . "/{$user->id}/field/avatar")
$this->delete(UserRepository::uriKey()."/{$user->id}/field/avatar")
->assertNotFound();
}

Expand All @@ -174,12 +174,12 @@ public function test_can_upload_file_using_storable()
UserRepository::partialMock()
->shouldReceive('fields')
->andReturn([
Image::make('avatar')->store(AvatarStore::class)
Image::make('avatar')->store(AvatarStore::class),
]);

$user = $this->mockUsers()->first();

$this->post(UserRepository::uriKey() . "/{$user->id}", [
$this->post(UserRepository::uriKey()."/{$user->id}", [
'avatar' => UploadedFile::fake()->image('image.jpg'),
])->assertOk()->assertJsonFragment([
'avatar' => '/storage/avatar.jpg',
Expand Down
1 change: 0 additions & 1 deletion tests/Fixtures/User/AvatarFile.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@

class AvatarFile extends File
{

}
2 changes: 1 addition & 1 deletion tests/Fixtures/User/AvatarStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class AvatarStore implements Storable
public function handle(Request $request, Model $model, $attribute): array
{
return [
'avatar' => $request->file('avatar')->storeAs('/', 'avatar.jpg', 'customDisk')
'avatar' => $request->file('avatar')->storeAs('/', 'avatar.jpg', 'customDisk'),
];
}
}
2 changes: 1 addition & 1 deletion tests/Fixtures/User/User.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class User extends Authenticatable implements Sanctumable, MustVerifyEmail, Rest
protected $fillable = [
'name', 'email', 'password', 'email_verified_at', 'avatar', 'created_at',
'avatar_size',
'avatar_original'
'avatar_original',
];

/**
Expand Down