Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Filters/SortableFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,10 @@ public function filter(RestifyRequest $request, $query, $direction)
$query->orderBy($this->column, $direction);
}

public function usingBelongsTo(BelongsTo $field)
public function usingBelongsTo(BelongsTo $field): self
{
$this->belongsToField = $field;

// $this->setColumn($field->attam ) //todo

return $this;
}

Expand Down
9 changes: 7 additions & 2 deletions src/Sort/SortCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ public function __construct($items = [])
? $item
: SortableFilter::make();

if ($queryKey instanceof SortableFilter) {
$unified[] = $queryKey;
continue;
}

$definition->setColumn(
$definition->column ?? $queryKey
);
Expand All @@ -34,7 +39,7 @@ public function __construct($items = [])

public function hydrateRepository(Repository $repository): self
{
return $this->map(fn (Filter $filter) => $filter->setRepository($repository));
return $this->each(fn (Filter $filter) => $filter->setRepository($repository));
}

public function allowed(RestifyRequest $request, Repository $repository)
Expand Down Expand Up @@ -73,6 +78,6 @@ public function forEager(RestifyRequest $request): self

public function normalize()
{
return $this->map(fn (SortableFilter $filter) => $filter->syncDirection());
return $this->each(fn (SortableFilter $filter) => $filter->syncDirection());
}
}
2 changes: 1 addition & 1 deletion src/Traits/InteractWithSearch.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ public static function collectSorts(RestifyRequest $request, Repository $reposit
{
return SortCollection::make(explode(',', $request->input('sort', '')))
->normalize()
->allowed($request, $repository)
->hydrateDefinition($repository)
->allowed($request, $repository)
->hydrateRepository($repository);
}

Expand Down
15 changes: 5 additions & 10 deletions tests/Feature/Filters/FilterDefinitionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@
use Binaryk\LaravelRestify\Filters\MatchFilter;
use Binaryk\LaravelRestify\Filters\SearchableFilter;
use Binaryk\LaravelRestify\Filters\SortableFilter;
use Binaryk\LaravelRestify\Http\Requests\RestifyRequest;
use Binaryk\LaravelRestify\Tests\Fixtures\Post\Post;
use Binaryk\LaravelRestify\Tests\Fixtures\Post\PostRepository;
use Binaryk\LaravelRestify\Tests\Fixtures\User\User;
use Binaryk\LaravelRestify\Tests\Fixtures\User\UserRepository;
use Binaryk\LaravelRestify\Tests\IntegrationTest;
use Illuminate\Database\Eloquent\Builder;

class FilterDefinitionTest extends IntegrationTest
{
Expand Down Expand Up @@ -72,14 +70,9 @@ public function test_can_filter_using_belongs_to_field()
];

PostRepository::$sort = [
'users.name' => SortableFilter::make()->usingBelongsTo(
'users.attributes.name' => SortableFilter::make()->setColumn('users.name')->usingBelongsTo(
BelongsTo::make('user', 'user', UserRepository::class),
)
/*function (RestifyRequest $request, Builder $builder, $direction) {
$builder->join('users', 'posts.user_id', '=', 'users.id')
->select('posts.*')
->orderBy('users.name', $direction);
}*/,
),
];

factory(Post::class)->create([
Expand All @@ -94,7 +87,9 @@ public function test_can_filter_using_belongs_to_field()
]),
]);

$json = $this->getJson(PostRepository::uriKey().'?related=user&sort=-users.name')
$json = $this
->withoutExceptionHandling()
->getJson(PostRepository::uriKey().'?related=user&sort=-users.attributes.name')
->json();

$this->assertSame(
Expand Down