Skip to content

Change return value of handle method in getter #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Change return value of handle method in getter #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Getters/Getter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@
use Illuminate\Support\Str;
use JsonSerializable;
use ReturnTypeWillChange;
use Symfony\Component\HttpFoundation\Response;
use function tap;
use function throw_unless;
use Throwable;

/**
* Class Getter
* @method JsonResponse handle(RestifyRequest $request, ?Model $model = null)
* @method Response|JsonResponse handle(RestifyRequest $request, ?Model $model = null)
* @package Binaryk\LaravelRestify\Getters
*/
abstract class Getter implements JsonSerializable
Expand Down Expand Up @@ -67,7 +68,7 @@ public function uriKey(): string
/**
* @throws Throwable
*/
public function handleRequest(GetterRequest $request): JsonResponse
public function handleRequest(GetterRequest $request): Response
{
throw_unless(method_exists($this, 'handle'), new Exception('Missing handle method from the getter.'));

Expand Down