Skip to content

fixing searchable key #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2025
Merged

fixing searchable key #656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ead765a
fix: fixing searchable key
binaryk Aug 30, 2025
c57ee74
Fix styling
binaryk Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Filters/SearchablesCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ public function __construct($items = [])
} elseif ($searchable instanceof Filter) {
// Other Filter instance - keep it
$unified[] = $searchable;
} elseif (is_string($searchable)) {
// String column name (including string callables like "MyClass::method")
$filter = new SearchableFilter;
$filter->setColumn($searchable);
$unified[] = $filter;
} elseif (is_string($key) && ! is_numeric($key)) {
// Array key is the field name
$filter = new SearchableFilter;
$filter->setColumn($key);
$unified[] = $filter;
} elseif (is_string($searchable)) {
// String column name (including string callables like "MyClass::method")
$filter = new SearchableFilter;
$filter->setColumn($searchable);
$unified[] = $filter;
} elseif (is_callable($searchable)) {
// Non-string callables (closures, arrays, invokables)
$filter = new SearchableFilter;
Expand Down