Skip to content

Conversation

@bgisme
Copy link
Contributor

@bgisme bgisme commented Feb 18, 2022

Shouldn't the class attribute be deleted after the last value is removed?

Otherwise you get...

Shouldn't the class attribute be deleted after the last value is removed?

Otherwise you get...

<Tag class=""></Tag>
@tib
Copy link
Member

tib commented Feb 18, 2022

Yeah, you are right about this, could you use the .isEmpty method instead of count == 0 please and also provide a short unit test to validate the change? Thank you.

testRemoveLastClass()

Assert that class attribute has been removed
@tib
Copy link
Member

tib commented Feb 18, 2022

Many thanks! :)

@tib tib merged commit 9e6389f into BinaryBirds:main Feb 18, 2022
@bgisme
Copy link
Contributor Author

bgisme commented Feb 18, 2022

Least I can do... Thank you.

@bgisme bgisme deleted the patch-12 branch March 18, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants