Update pairing mechanism and add MAC #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasbakkum
force-pushed
the
180730/hmac
branch
3 times, most recently
from
e8c5f54 to
99d5fa6
Compare
douglasbakkum
force-pushed
the
180730/hmac
branch
from
99d5fa6 to
7536c93
Compare
x1ddos
reviewed
Jul 31, 2018
| unsigned char enc[inpadlen]; | ||
| unsigned char iv[N_BLOCK]; | ||
| uint8_t *enc_cat = malloc(sizeof(uint8_t) * (inpadlen + | ||
| N_BLOCK)); // concatenating [ iv0 | enc ] |
There was a problem hiding this comment.
I guess it would be a lot of work but just curious. Would it make sense to try and get rid of malloc? The aescbcb64_init_and_encrypt could take one additional arg, pointer to a enc_cat. They would call a hypothetical aescbcb64_encrypt_len upfront to get the size of how much they need to allocate.
Here and on other malloc places below.
douglasbakkum
pushed a commit
that referenced
this pull request
Jul 31, 2018
7536c93 Update pairing mechanism and add MAC (Stephanie Stroka)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pairing between device and mobile app and use an hmac. The ECDH code is removed from
commander.cand put intoecdh.c. The led abort command was deprecated while the led blink command was modified to blink 5 times quickly.