Skip to content

feat(sdk-core): add signer address in signMessage intent #6903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

feat(sdk-core): add signer address in signMessage intent #6903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ export interface Message extends BaseSignable {
messageRaw: string;
messageEncoded?: string;
messageStandardType?: MessageStandardType;
signerAddress?: string;
}

export interface MessageTypeProperty {
Expand Down
1 change: 1 addition & 0 deletions modules/sdk-core/src/bitgo/utils/tss/baseTSSUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ export default class BaseTssUtils<KeyShare> extends MpcUtils implements ITssUtil
messageRaw: params.messageRaw,
messageStandardType: params.messageStandardType ?? MessageStandardType.UNKNOWN,
messageEncoded: params.messageEncoded ?? '',
signerAddress: params.signerAddress,
};

return this.buildSignMessageRequestBase(intent, apiVersion, params.reqId);
Expand Down
2 changes: 2 additions & 0 deletions modules/sdk-core/src/bitgo/utils/tss/baseTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ export interface IntentOptionsForMessage extends IntentOptionsBase {
messageRaw: string;
messageEncoded?: string;
messageStandardType?: MessageStandardType;
signerAddress?: string;
}

export interface IntentOptionsForTypedData extends IntentOptionsBase {
Expand Down Expand Up @@ -244,6 +245,7 @@ export interface PopulatedIntentForMessageSigning extends PopulatedIntentBase {
messageEncoded: string;
custodianMessageId?: string;
messageStandardType?: MessageStandardType;
signerAddress?: string;
}

export interface PopulatedIntentForTypedDataSigning extends PopulatedIntentBase {
Expand Down
1 change: 1 addition & 0 deletions modules/sdk-core/src/bitgo/wallet/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,6 +2133,7 @@ export class Wallet implements IWallet {
isTss: true,
messageRaw,
messageStandardType,
signerAddress: params.message.signerAddress,
};

if (!this.tssUtils) {
Expand Down