Skip to content

feat(sdk-core): skip type check for STX #7182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

feat(sdk-core): skip type check for STX #7182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/sdk-core/src/bitgo/staking/stakingWallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ export class StakingWallet implements IStakingWallet {
);
}

private isStx() {
return this.wallet.baseCoin.getFamily() === 'stx';
}

private isTrxStaking(transaction: StakingTransaction) {
return this.wallet.baseCoin.getFamily() === 'trx';
}
Expand Down Expand Up @@ -448,7 +452,8 @@ export class StakingWallet implements IStakingWallet {
if (
buildParams?.type &&
(explainedTransaction as any).type !== undefined &&
TransactionType[buildParams.type] !== (explainedTransaction as any).type
((this.isStx() && TransactionType.ContractCall !== (explainedTransaction as any).type) || // for STX the tx type should always ContractCall
(!this.isStx() && TransactionType[buildParams.type] !== (explainedTransaction as any).type))
) {
mismatchErrors.push(
`Transaction type mismatch. Expected: '${buildParams.type}', Got: '${(explainedTransaction as any).type}'`
Expand Down