Skip to content

feat(sdk-core): improve ParsedTransaction interface type #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
+11 −5
Merged

feat(sdk-core): improve ParsedTransaction interface type #7441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,14 @@ export interface ParseTransactionOptions {
[index: string]: unknown;
}

// TODO (SDKT-9): reverse engineer and add options
/**
* This is only used for determining the PayGo fee of a transaction which is only relevant for UTXO coins.
* Some coins return various other fields here, but they are only used internally by the respective coins.
*/
export interface ParsedTransaction {
// the callsite assumes that this is the PayGo amount
implicitExternalSpendAmount?: number | bigint;
// coins may add internal fields
[index: string]: unknown;
}

Expand Down
8 changes: 4 additions & 4 deletions modules/sdk-core/src/bitgo/pendingApproval/pendingApproval.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,16 +304,16 @@ export class PendingApproval implements IPendingApproval {
prebuildParams = _.extend({}, prebuildParams, { reqId: reqId });
const signedTransaction = await this.wallet.prebuildAndSignTransaction(prebuildParams);
// compare PAYGo fees
const originalParsedTransaction = (await this.baseCoin.parseTransaction({
const originalParsedTransaction = await this.baseCoin.parseTransaction({
txParams: prebuildParams,
wallet: this.wallet,
txPrebuild: originalPrebuild,
})) as any;
const recreatedParsedTransaction = (await this.baseCoin.parseTransaction({
});
const recreatedParsedTransaction = await this.baseCoin.parseTransaction({
txParams: prebuildParams,
wallet: this.wallet,
txPrebuild: signedTransaction,
})) as any;
});

if (_.isUndefined(recreatedParsedTransaction.implicitExternalSpendAmount)) {
return signedTransaction;
Expand Down