feat(abstract-utxo): improve transaction handling tests and assertions #7443
+554
−530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te files Improves organization by splitting large test file into separate focused files for parseTransaction, explainTransaction, and verifyTransaction. Issue: BTC-2732 Co-authored-by: llm-git <llm-git@ttll.de>
Update test assertions to use Node's built-in assert module instead of should.js. This improves code consistency and reduces dependencies. Issue: BTC-2732 Co-authored-by: llm-git <llm-git@ttll.de>
Refactor tests to use afterEach cleanup pattern instead of manual restore calls. Add proper TypeScript typing to test function parameters. Issue: BTC-2732 Co-authored-by: llm-git <llm-git@ttll.de>
davidkaplanbitgo
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several improvements to the abstract-utxo transaction handling
tests:
Split large transaction handling test file into separate focused files
for parseTransaction, explainTransaction, and verifyTransaction to
improve organization
Replace should.js with Node's built-in assert module to improve code
consistency and reduce dependencies
Improve parseTransaction tests with proper TypeScript typing and a
cleaner afterEach cleanup pattern
Issue: BTC-2732