feat(sdk-api): pass isTestTransaction parameter to TSS transfer txrequests API and Multisig sendMany API #7449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandra-wang-bitgo
force-pushed
the
sandra/cs-6339
branch
from
c27421e to
bd862b8
Compare
sandra-wang-bitgo
changed the title
sandra-wang-bitgo
force-pushed
the
sandra/cs-6339
branch
from
bd862b8 to
ab5274f
Compare
sandra-wang-bitgo
changed the title
sandra-wang-bitgo
force-pushed
the
sandra/cs-6339
branch
3 times, most recently
from
63e6afe to
fee8b8b
Compare
for withdrawals Add isTestTransaction parameter support for wallet transactions: - Add isTestTransaction to PrebuildTransactionOptions interface (available for both TSS and multisig wallets) - Pass isTestTransaction through prebuildTransactionTxRequests for TSS transfer transactions - Include isTestTransaction in PopulatedIntent and baseIntent objects for TSS wallet flow - SendManyOptions inherits isTestTransaction via PrebuildAndSignTransactionOptions Add comprehensive test coverage: - Test isTestTransaction is passed through prebuildTransaction for TSS wallets - Test isTestTransaction flows through sendMany to prebuildAndSignTransaction - Add proper TypeScript assertions with existence checks This ensures the isTestTransaction flag is correctly sent to the /api/v2/wallet/:walletId/txrequests endpoint for TSS wallets (e.g., NEAR) and is available for multisig wallets when building transfer transactions via prebuildTransaction() or sendMany(). TICKET: CS-6399
sandra-wang-bitgo
force-pushed
the
sandra/cs-6339
branch
from
fee8b8b to
1e1253d
Compare
Contributor
Author
|
related WP PR: https://github.com/BitGo/bitgo-microservices/pull/53063 |
mukeshsp
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
isTestTransactionparameter in wallet transactions for both TSS and multisig wallets. The parameter can now be passed throughprebuildTransaction()andsendMany()methods and will be correctly sent to the API.Problem
We want to send
isTestTransactionto indicate that the client wants to initiate a test transaction which should be under 25 USD to an unverified to-be-whitelisted address.Solution
Code Changes
Added
isTestTransactionto interfaces:PrebuildTransactionOptions- makes it available for both TSS and multisig walletsPopulatedIntent- ensures it's included in the intent sent to the APIPass parameter through the TSS flow:
prebuildTransactionTxRequests()to includeisTestTransactionfor transfer transactionspopulateIntent()inmpcUtils.tsto includeisTestTransactionin the base intentInheritance for
sendMany():SendManyOptionsinheritsisTestTransactionviaPrebuildAndSignTransactionOptions→PrebuildTransactionOptionsTest Coverage
Added comprehensive unit tests:
isTestTransactionis correctly passed fromprebuildTransaction()toprebuildTxWithIntent()for TSS walletsisTestTransactionflows throughsendMany()→prebuildAndSignTransaction()→prebuildTransaction()TICKET: CS-6339