Skip to content

feat(statics): support message signing for bsc and polygon #7470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

feat(statics): support message signing for bsc and polygon #7470

merged 1 commit into from
Nov 10, 2025
+8 −0

Conversation

@derekchen745
Copy link
Contributor

@derekchen745 derekchen745 commented Nov 10, 2025 •
edited
Loading

Ticket: SC-3812

  • bsc already had the message builder, mapping and the EVM_SHARED_MESSAGE_SIGNING flag. It had supportsMessageSigning(), but was missing supportsSigningTypedData
  • polygon had both supportsMessageSigning() and supportsSigningTypedData, but was missing the EVM_SHARED_MESSAGE_SIGNING and the message builder mapping

@derekchen745 derekchen745 marked this pull request as ready for review November 10, 2025 17:25
@derekchen745 derekchen745 requested review from a team as code owners November 10, 2025 17:25
@derekchen745 derekchen745 merged commit e27bdac into master Nov 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benkelcher-bitgo benkelcher-bitgo benkelcher-bitgo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derekchen745 @benkelcher-bitgo