Skip to content

Conversation

@OttoAllmendinger
Copy link
Contributor

This PR refactors replay protection functionality in the abstract-utxo
module to improve testability and organization:

  1. Extracted replay protection addresses parameter to replace internal call
    to isReplayProtectionUnspent with an explicit parameter
  2. Added replayProtectionAddresses parameter to signAndVerifyWalletTransaction
    with fallback to existing values
  3. Moved replay protection and signing code to more appropriate locations:
    • Relocated replayProtection.ts to transaction/fixedScript/
    • Relocated sign.ts to transaction/fixedScript/
    • Updated all import references throughout the codebase

Issue: BTC-2806

OttoAllmendinger and others added 2 commits November 28, 2025 10:29
Replace internal call to isReplayProtectionUnspent with explicit param to
allow better testing. Add replayProtectionAddresses parameter to
signAndVerifyWalletTransaction with fallback to existing values.

Issue: BTC-2806

Co-authored-by: llm-git <llm-git@ttll.de>
…n/fixedScript

Move files to their appropriate locations:
- Move replayProtection.ts to transaction/fixedScript/
- Move sign.ts to transaction/fixedScript/
- Update all import references throughout the codebase

Issue: BTC-2806

Co-authored-by: llm-git <llm-git@ttll.de>
@OttoAllmendinger OttoAllmendinger marked this pull request as ready for review November 28, 2025 09:54
@OttoAllmendinger OttoAllmendinger requested a review from a team as a code owner November 28, 2025 09:54
@OttoAllmendinger OttoAllmendinger merged commit 71366cd into master Nov 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants