ci: migrate to OIDC trusted publishing #12
Merged
+1,121
−573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanjeemh
force-pushed
the
DX-2083-trusted-publishing
branch
from
516e460 to
251fbaa
Compare
Ticket: DX-2083
tanjeemh
force-pushed
the
DX-2083-trusted-publishing
branch
2 times, most recently
from
bc184bf to
1af26a8
Compare
starfy84
requested changes
Nov 13, 2025
starfy84
left a comment
starfy84
left a comment
There was a problem hiding this comment.
Great work!
Had a quick question about removing --frozen-lockfile. Also, it seems like we've updated the package.json without committing the associated changes to the lock file
tanjeemh
force-pushed
the
DX-2083-trusted-publishing
branch
from
1af26a8 to
d67e76e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
22.xto resolve version mismatch errorid-token: writepermissions to allow for OIDC authenvironment: publishto enforce npmjs release securitysemantic-release/npmto v13.1.1 to comply with OIDC Trusted PublishingWhy solve it this way?
As classic npm tokens are being revoked as per npmjs notices, this PR is part of the overarching epic to migrate to using OIDC Trusted Publishing.
The addition of environments enforces custom branch deployment, ensuring that a random person can't just initiate a release.
Ticket: DX-2083