fix: use makefile for build:wasm #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a more complex build process to be managed in a Makefile. Turns out we have to remove the `.gitignore` files from the output directories after `wasm-pack` builds the files, otherwise `npm pack` will not pick up the wasm files. Issue: BTC-1372
saravanan7mani
approved these changes
Aug 12, 2024
OttoAllmendinger
added a commit
that referenced
this pull request
Nov 7, 2025
feat(wasm-utxo): implement MuSig2 finalization support for PSBT handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a more complex build process to be managed in a Makefile.
Turns out we have to remove the
.gitignorefiles from the output directoriesafter
wasm-packbuilds the files, otherwisenpm packwill not pick up thewasm files.
Issue: BTC-1372