feat: improve taproot descriptors support #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
force-pushed
the
BTC-1829.fix-taproot
branch
2 times, most recently
from
fe54016 to
9e85727
Compare
Add helper to write descriptor AST to JSON files for test fixtures. Issue: BTC-1829
Add test fixtures and validation for taproot descriptor support. Handle Tr type scriptpubkey length checks. Issue: BTC-1829
Change Tr descriptor output from object to array format to match test fixtures. Internal key and tap tree are now returned as array elements. Issue: BTC-1829
OttoAllmendinger
force-pushed
the
BTC-1829.fix-taproot
branch
from
9e85727 to
ca1c430
Compare
saravanan7mani
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation and AST output for taproot descriptors. Change Tr descriptor
output format from object to array to match test fixtures. Handle Tr type
scriptpubkey length checks.
BTC-1829