Skip to content

feat: update wasm-miniscript package and dependencies #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2025
Merged

feat: update wasm-miniscript package and dependencies #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c649f9
feat: update wasm-miniscript to use latest dependencies
OttoAllmendinger Feb 12, 2025
4052f22
fix: strip release binary to make webpack happy
OttoAllmendinger Feb 12, 2025
071a8d7
fix: add browser wasm file to sideEffects
OttoAllmendinger Feb 12, 2025
cb3d3e2
fix: include test dir in tsconfig
OttoAllmendinger Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 59 additions & 39 deletions packages/wasm-miniscript/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions packages/wasm-miniscript/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,8 @@ crate-type = ["cdylib"]
wasm-bindgen = "0.2"
js-sys = "0.3"
miniscript = { version = "12.3.0" }

[profile.release]
# this is required to make webpack happy
# https://github.com/webpack/webpack/issues/15566#issuecomment-2558347645
strip = true
8 changes: 4 additions & 4 deletions packages/wasm-miniscript/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ endef
js/wasm/:
$(call BUILD,$@,nodejs)

.PHONY: dist/wasm/
dist/wasm/:
.PHONY: dist/node/js/wasm/
dist/node/js/wasm/:
$(call BUILD,$@,nodejs)

.PHONY: dist/browser/wasm/
dist/browser/wasm/:
.PHONY: dist/browser/js/wasm/
dist/browser/js/wasm/:
$(call BUILD,$@,browser)
41 changes: 16 additions & 25 deletions packages/wasm-miniscript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,38 +7,29 @@
"url": "git+https://github.com/BitGo/wasm-miniscript.git"
},
"files": [
"dist/wasm/wasm_miniscript.d.ts",
"dist/wasm/wasm_miniscript.js",
"dist/wasm/wasm_miniscript_bg.wasm",
"dist/wasm/wasm_miniscript_bg.wasm.d.ts",
"dist/browser/wasm/wasm_miniscript.d.ts",
"dist/browser/wasm/wasm_miniscript.js",
"dist/browser/wasm/wasm_miniscript_bg.js",
"dist/browser/wasm/wasm_miniscript_bg.wasm",
"dist/browser/wasm/wasm_miniscript_bg.wasm.d.ts",
"dist/browser/index.d.ts",
"dist/browser/index.js",
"dist/index.js",
"dist/index.d.ts"
"dist/*/js/wasm/wasm_miniscript.d.ts",
"dist/*/js/wasm/wasm_miniscript.js",
"dist/*/js/wasm/wasm_miniscript_bg.js",
"dist/*/js/wasm/wasm_miniscript_bg.wasm",
"dist/*/js/wasm/wasm_miniscript_bg.wasm.d.ts",
"dist/*/js/index.d.ts",
"dist/*/js/index.js"
],
"main": "dist/index.js",
"types": "dist/index.d.ts",
"main": "dist/node/js/index.js",
"types": "dist/node/js/index.d.ts",
"sideEffects": [
"./dist/wasm/wasm_miniscript.js"
"./dist/node/js/wasm/wasm_miniscript.js",
"./dist/browser/js/wasm/wasm_miniscript.js"
],
"browser": {
"./dist/index.js": "./dist/browser/index.js",
"./dist/index.d.ts": "./dist/browser/index.d.ts",
"./dist/wasm/wasm_miniscript_bg.wasm": "./dist/browser/wasm/wasm_miniscript_bg.wasm",
"./dist/wasm/wasm_miniscript.js": "./dist/browser/wasm/wasm_miniscript.js",
"./dist/wasm/wasm_miniscript_bg.js": "./dist/browser/wasm/wasm_miniscript_bg.js",
"./dist/wasm/wasm_miniscript.d.ts": "./dist/browser/wasm/wasm_miniscript.d.ts"
"./dist/node/js/index.js": "./dist/browser/js/index.js"
},
"scripts": {
"test": "mocha --recursive test",
"build:wasm": "make js/wasm/ && make dist/wasm/ && make dist/browser/wasm/",
"build:ts-browser": "tsc --module es2020 --target es2020 --outDir dist/browser",
"build:ts": "tsc && npm run build:ts-browser",
"build:wasm": "make js/wasm/ && make dist/node/js/wasm/ && make dist/browser/js/wasm/",
"build:ts-browser": "tsc --noEmit false --module es2020 --target es2020 --outDir dist/browser",
"build:ts-node": "tsc --noEmit false --outDir dist/node",
"build:ts": "npm run build:ts-browser && npm run build:ts-node",
"build": "npm run build:wasm && npm run build:ts",
"check-fmt": "prettier --check . && cargo fmt -- --check"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/wasm-miniscript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"allowJs": true,
"skipLibCheck": true,
"declaration": true,
"outDir": "dist"
"noEmit": true
},
"include": ["./js/index.ts"],
"include": ["./js/**/*.ts", "test/**/*.ts"],
"exclude": ["node_modules", "./js/wasm/**/*"]
}